Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing --device option to build-ios command #2482

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Fixes #2473

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js build-ios --device

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added bugfix docs Documentation change labels Aug 23, 2024
@szymonrybczak szymonrybczak force-pushed the fix/add-missing-device-option branch from 10220dd to 1a0613f Compare August 23, 2024 06:34
@thymikee thymikee merged commit 3a84d86 into main Aug 23, 2024
10 checks passed
@thymikee thymikee deleted the fix/add-missing-device-option branch August 23, 2024 07:42
@jenskuhrjorgensen
Copy link

Hi @szymonrybczak

I can see that it has been a long time since the last release of this lib (April). Do you have a release planned in the nearest future?

Best regards
Jens

@szymonrybczak
Copy link
Collaborator Author

hey @jenskuhrjorgensen, it's included in React Native 0.75.3, and will be included in upcoming 0.76 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix docs Documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native build-ios error: unknown option '--device'
3 participants